Re: [PATCH net-next] sfc: remove udp_tnl_has_port

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 23:02:09 +0100 Edward Cree wrote: > On 01/07/2020 19:43, Jakub Kicinski wrote: > > There's a number of drivers which try to match the UDP ports. That > > seems fragile to me. Is it actually required for HW to operate > > correctly? > For EF10 hardware, yes, because the hardwar

Re: [PATCH net-next] sfc: remove udp_tnl_has_port

2020-07-01 Thread Edward Cree
On 01/07/2020 19:43, Jakub Kicinski wrote: > There's a number of drivers which try to match the UDP ports. That > seems fragile to me. Is it actually required for HW to operate > correctly? For EF10 hardware, yes, because the hardware parses the packet headers  to find for itself the offsets at wh

Re: [PATCH net-next] sfc: remove udp_tnl_has_port

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 15:32:03 +0100 Edward Cree wrote: > On 30/06/2020 23:50, Jakub Kicinski wrote: > > Nothing seems to have ever been calling this. > > > > Signed-off-by: Jakub Kicinski > That was intended to be used by encap offloads (TX csum and TSO), which >  we only recently realised we hadn

Re: [PATCH net-next] sfc: remove udp_tnl_has_port

2020-07-01 Thread Edward Cree
On 30/06/2020 23:50, Jakub Kicinski wrote: > Nothing seems to have ever been calling this. > > Signed-off-by: Jakub Kicinski That was intended to be used by encap offloads (TX csum and TSO), which  we only recently realised we hadn't upstreamed the rest of; the  udp_tnl_has_port method would be ca

[PATCH net-next] sfc: remove udp_tnl_has_port

2020-06-30 Thread Jakub Kicinski
Nothing seems to have ever been calling this. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/sfc/ef10.c | 23 --- drivers/net/ethernet/sfc/net_driver.h | 2 -- 2 files changed, 25 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet