Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-14 Thread David Miller
From: Xin Long Date: Thu, 14 Jun 2018 07:37:02 +0800 > Now sctp GSO uses skb_gro_receive() to append the data into head > skb frag_list. However it actually only needs very few code from > skb_gro_receive(). Besides, NAPI_GRO_CB has to be set while most > of its members are not needed here. > >

Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-14 Thread Neil Horman
On Wed, Jun 13, 2018 at 07:05:59PM -0700, David Miller wrote: > From: Neil Horman > Date: Wed, 13 Jun 2018 20:46:43 -0400 > > > Do you have any performance numbers to compare with and without this > > patch? Adding a function like this implies that any fixes that go > > into skb_gro_receive now

Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-14 Thread Neil Horman
On Thu, Jun 14, 2018 at 09:21:52AM +0800, Xin Long wrote: > On Thu, Jun 14, 2018 at 8:46 AM, Neil Horman wrote: > > On Thu, Jun 14, 2018 at 07:37:02AM +0800, Xin Long wrote: > >> Now sctp GSO uses skb_gro_receive() to append the data into head > >> skb frag_list. However it actually only needs ver

Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-13 Thread David Miller
From: Neil Horman Date: Wed, 13 Jun 2018 20:46:43 -0400 > Do you have any performance numbers to compare with and without this > patch? Adding a function like this implies that any fixes that go > into skb_gro_receive now need to be evaluated for this function too, > which means theres an implie

Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-13 Thread Xin Long
On Thu, Jun 14, 2018 at 8:46 AM, Neil Horman wrote: > On Thu, Jun 14, 2018 at 07:37:02AM +0800, Xin Long wrote: >> Now sctp GSO uses skb_gro_receive() to append the data into head >> skb frag_list. However it actually only needs very few code from >> skb_gro_receive(). Besides, NAPI_GRO_CB has to

Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-13 Thread Neil Horman
On Thu, Jun 14, 2018 at 07:37:02AM +0800, Xin Long wrote: > Now sctp GSO uses skb_gro_receive() to append the data into head > skb frag_list. However it actually only needs very few code from > skb_gro_receive(). Besides, NAPI_GRO_CB has to be set while most > of its members are not needed here. >

Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-13 Thread Marcelo Ricardo Leitner
On Thu, Jun 14, 2018 at 07:37:02AM +0800, Xin Long wrote: > Now sctp GSO uses skb_gro_receive() to append the data into head > skb frag_list. However it actually only needs very few code from > skb_gro_receive(). Besides, NAPI_GRO_CB has to be set while most > of its members are not needed here. >

[PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames

2018-06-13 Thread Xin Long
Now sctp GSO uses skb_gro_receive() to append the data into head skb frag_list. However it actually only needs very few code from skb_gro_receive(). Besides, NAPI_GRO_CB has to be set while most of its members are not needed here. This patch is to add sctp_packet_gso_append() to build GSO frames i