Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-02 Thread Eric Dumazet
On Fri, 2016-09-02 at 14:14 +0300, Rami Rosen wrote: > Hi Eric, > > Nice catch! > This warning does not occur under certain gcc versions. > For example, gcc 4.8.4 (ubuntu 14.04); it does occur, for example, > under gcc 5.3.1 for example (Fedora 24). > > I just sent a patch to fix this. > Thank

Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-02 Thread Rami Rosen
Hi Eric, Nice catch! This warning does not occur under certain gcc versions. For example, gcc 4.8.4 (ubuntu 14.04); it does occur, for example, under gcc 5.3.1 for example (Fedora 24). I just sent a patch to fix this. Regards, Rami Rosen

Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-01 Thread Eric Dumazet
On Tue, 2016-08-30 at 21:56 -0700, Roopa Prabhu wrote: > From: Roopa Prabhu > @@ -342,7 +342,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff > *skb, > struct netlink_callback *cb, > struct net_device *d

Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-01 Thread David Miller
From: Roopa Prabhu Date: Tue, 30 Aug 2016 21:56:45 -0700 > From: Roopa Prabhu > > fdb dumps spanning multiple skb's currently restart from the first > interface again for every skb. This results in unnecessary > iterations on the already visited interfaces and their fdb > entries. In large scal

[PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-08-30 Thread Roopa Prabhu
From: Roopa Prabhu fdb dumps spanning multiple skb's currently restart from the first interface again for every skb. This results in unnecessary iterations on the already visited interfaces and their fdb entries. In large scale setups, we have seen this to slow down fdb dumps considerably. On a s