Re: [PATCH net-next] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-17 Thread Thomas Graf
On 07/17/15 at 10:28am, Eric Dumazet wrote: > On Fri, 2015-07-17 at 10:24 +0200, Eric Dumazet wrote: > > > Please simply use cond_resched() without counting and magic value. Done > Also use cond_resched() in insert and delete phases ? When I tried that it made the walker duplicates disappear wh

Re: [PATCH net-next] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-17 Thread Eric Dumazet
On Fri, 2015-07-17 at 10:24 +0200, Eric Dumazet wrote: > Please simply use cond_resched() without counting and magic value. Also use cond_resched() in insert and delete phases ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kerne

Re: [PATCH net-next] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-17 Thread Eric Dumazet
On Fri, 2015-07-17 at 10:07 +0200, Thomas Graf wrote: > Depending on system speed, the large lookup loop can take a considerable > amount of time to complete causing watchdog warnings to appear. Allow > other tasks to be scheduled after every batch of 1000 lookups. > > Reported-by: Meelis Roos >

[PATCH net-next] rhashtable: Allow other tasks to be scheduled in large lookup loops

2015-07-17 Thread Thomas Graf
Depending on system speed, the large lookup loop can take a considerable amount of time to complete causing watchdog warnings to appear. Allow other tasks to be scheduled after every batch of 1000 lookups. Reported-by: Meelis Roos Signed-off-by: Thomas Graf --- lib/test_rhashtable.c | 9 +++