Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-03 Thread Jakub Kicinski
On Sun, 1 Nov 2020 23:30:44 +0100 Heiner Kallweit wrote: > We had to remove flag IRQF_NO_THREAD because it conflicts with shared > interrupts in case legacy interrupts are used. Following up on the > linked discussion set IRQF_NO_THREAD if MSI or MSI-X is used, because > both guarantee that interru

Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-02 Thread Vladimir Oltean
On Mon, Nov 02, 2020 at 04:18:07PM +0100, Heiner Kallweit wrote: > According to my understanding the point is that executing the simple > hard irq handler for NAPI drivers doesn't cost significantly more than > executing the default hard irq handler (irq_default_primary_handler). > Therefore thread

Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-02 Thread Heiner Kallweit
On 02.11.2020 13:41, Vladimir Oltean wrote: > On Mon, Nov 02, 2020 at 09:01:00AM +0100, Heiner Kallweit wrote: >> As mentioned by Eric it doesn't make sense to make the minimal hard irq >> handlers used with NAPI a thread. This more contributes to the problem >> than to the solution. The change her

Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-02 Thread Vladimir Oltean
On Mon, Nov 02, 2020 at 09:01:00AM +0100, Heiner Kallweit wrote: > As mentioned by Eric it doesn't make sense to make the minimal hard irq > handlers used with NAPI a thread. This more contributes to the problem > than to the solution. The change here reflects this. When you say that "it doesn't m

Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-02 Thread Heiner Kallweit
On 02.11.2020 01:06, Vladimir Oltean wrote: > On Sun, Nov 01, 2020 at 11:30:44PM +0100, Heiner Kallweit wrote: >> We had to remove flag IRQF_NO_THREAD because it conflicts with shared >> interrupts in case legacy interrupts are used. Following up on the >> linked discussion set IRQF_NO_THREAD if MS

Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-01 Thread Vladimir Oltean
On Sun, Nov 01, 2020 at 11:30:44PM +0100, Heiner Kallweit wrote: > We had to remove flag IRQF_NO_THREAD because it conflicts with shared > interrupts in case legacy interrupts are used. Following up on the > linked discussion set IRQF_NO_THREAD if MSI or MSI-X is used, because > both guarantee that

[PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-01 Thread Heiner Kallweit
We had to remove flag IRQF_NO_THREAD because it conflicts with shared interrupts in case legacy interrupts are used. Following up on the linked discussion set IRQF_NO_THREAD if MSI or MSI-X is used, because both guarantee that interrupt won't be shared. Signed-off-by: Heiner Kallweit Link: https: