Re: [PATCH net-next] r8169: remove unneeded memory barrier in rtl_tx

2020-10-31 Thread Jakub Kicinski
On Thu, 29 Oct 2020 18:56:06 +0100 Heiner Kallweit wrote: > tp->dirty_tx isn't changed outside rtl_tx(). Therefore I see no need > to guarantee a specific order of reading tp->dirty_tx and tp->cur_tx. > Having said that we can remove the memory barrier. > In addition use READ_ONCE() when reading tp

[PATCH net-next] r8169: remove unneeded memory barrier in rtl_tx

2020-10-29 Thread Heiner Kallweit
tp->dirty_tx isn't changed outside rtl_tx(). Therefore I see no need to guarantee a specific order of reading tp->dirty_tx and tp->cur_tx. Having said that we can remove the memory barrier. In addition use READ_ONCE() when reading tp->cur_tx because it can change in parallel to rtl_tx(). Signed-of