Re: [PATCH net-next] r8169: let mdio read functions return -ETIMEDOUT

2019-06-13 Thread David Miller
From: Heiner Kallweit Date: Tue, 11 Jun 2019 21:04:09 +0200 > In case of a timeout currently ~0 is returned. Callers often just check > whether a certain bit is set and therefore may behave incorrectly. > So let's return -ETIMEDOUT in case of a timeout. > > r8168_phy_ocp_read is used in r8168g_m

[PATCH net-next] r8169: let mdio read functions return -ETIMEDOUT

2019-06-11 Thread Heiner Kallweit
In case of a timeout currently ~0 is returned. Callers often just check whether a certain bit is set and therefore may behave incorrectly. So let's return -ETIMEDOUT in case of a timeout. r8168_phy_ocp_read is used in r8168g_mdio_read only, therefore we can apply the same change. Signed-off-by: H