Re: [PATCH net-next] r8169: improve firmware handling

2019-01-23 Thread David Miller
From: Heiner Kallweit Date: Tue, 22 Jan 2019 22:23:41 +0100 > So far member rtl_fw has three states: > - IS_ERR(rtl_fw): firmware not loaded > - !rtl_fw: no firmware available > - other: firmware loaded > > This can be made simpler and clearer by adding the firmware name as > member fw_name to s

[PATCH net-next] r8169: improve firmware handling

2019-01-22 Thread Heiner Kallweit
So far member rtl_fw has three states: - IS_ERR(rtl_fw): firmware not loaded - !rtl_fw: no firmware available - other: firmware loaded This can be made simpler and clearer by adding the firmware name as member fw_name to struct rtl8169_private. Then: - !fw_name: no firmware available - !rtl_fw: f