Re: [PATCH net-next] qed: Fix an off by one bug

2017-06-14 Thread David Miller
From: Dan Carpenter Date: Wed, 14 Jun 2017 12:10:10 +0300 > The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so > the > here should be a >= or we write beyond the end of the array. > > Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid") > Signed-off-by:

RE: [PATCH net-next] qed: Fix an off by one bug

2017-06-14 Thread Mintz, Yuval
> The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so > the > here should be a >= or we write beyond the end of the array. > > Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid") > Signed-off-by: Dan Carpenter While it's a theoretical fix [as check is de

[PATCH net-next] qed: Fix an off by one bug

2017-06-14 Thread Dan Carpenter
The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so the > here should be a >= or we write beyond the end of the array. Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c