Re: [PATCH net-next] net_sched: fix error recovery at qdisc creation

2017-02-11 Thread David Miller
From: Eric Dumazet Date: Fri, 10 Feb 2017 10:31:49 -0800 > From: Eric Dumazet > > Dmitry reported uses after free in qdisc code [1] > > The problem here is that ops->init() can return an error. > > qdisc_create_dflt() then call ops->destroy(), > while qdisc_create() does _not_ call it. > > F

[PATCH net-next] net_sched: fix error recovery at qdisc creation

2017-02-10 Thread Eric Dumazet
From: Eric Dumazet Dmitry reported uses after free in qdisc code [1] The problem here is that ops->init() can return an error. qdisc_create_dflt() then call ops->destroy(), while qdisc_create() does _not_ call it. Four qdisc chose to call their own ops->destroy(), assuming their caller would n