Re: [PATCH net-next] net: stmmac: fix missing unlock on error in stmmac_suspend()

2021-03-16 Thread Edmundo Carmona Antoranz
On Tue, Mar 16, 2021 at 7:50 AM Edmundo Carmona Antoranz wrote: > I think you can let it go and check ret after unlocking: > > /* Disable clock in case of PWM is off */ >clk_disable_unprepare(priv->plat->clk_ptp_ref); >ret = pm_runtime_force_suspend

[PATCH net-next] net: stmmac: fix missing unlock on error in stmmac_suspend()

2021-03-16 Thread 'w00385741
From: Wei Yongjun Add the missing unlock before return from function stmmac_suspend() in the error handling case. Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c