Hi David,
On 23-04-2018 01:59, David Miller wrote:
> From: Jose Abreu
> Date: Thu, 19 Apr 2018 16:24:15 +0100
>
>> @@ -0,0 +1,216 @@
>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +// Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
>> +// stmmac HW Interface Handling
> Please do not
From: Jose Abreu
Date: Thu, 19 Apr 2018 16:24:15 +0100
> @@ -0,0 +1,216 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +// Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> +// stmmac HW Interface Handling
Please do not use C++ style comments for anything past the
SPDX identifier
Move all the core version detection to a common place ("hwif.c") and
implement a table which can be used to lookup the correct callbacks for
each IP version.
This simplifies the initialization flow of each IP version and eases
future implementation of new IP versions.
Signed-off-by: Jose Abreu
C
