Re: [PATCH net-next] net: set initial device refcount to 1

2021-03-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 22 Mar 2021 11:21:45 -0700 you wrote: > From: Eric Dumazet > > When adding CONFIG_PCPU_DEV_REFCNT, I forgot that the > initial net device refcount was 0. > > When CONFIG_PCPU_DEV_REFCNT is not set, this means > t

Re: [PATCH net-next] net: set initial device refcount to 1

2021-03-22 Thread David Miller
From: David Miller Date: Mon, 22 Mar 2021 16:55:26 -0700 (PDT) > From: Eric Dumazet > Date: Mon, 22 Mar 2021 11:21:45 -0700 > > This hunk: >> @@ -10682,6 +10682,9 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, >> const char *name, >> dev->pcpu_refcnt = alloc_percpu(int); >>

Re: [PATCH net-next] net: set initial device refcount to 1

2021-03-22 Thread David Miller
From: Eric Dumazet Date: Mon, 22 Mar 2021 11:21:45 -0700 > From: Eric Dumazet > > When adding CONFIG_PCPU_DEV_REFCNT, I forgot that the > initial net device refcount was 0. > > When CONFIG_PCPU_DEV_REFCNT is not set, this means > the first dev_hold() triggers an illegal refcount > operation (a

[PATCH net-next] net: set initial device refcount to 1

2021-03-22 Thread Eric Dumazet
From: Eric Dumazet When adding CONFIG_PCPU_DEV_REFCNT, I forgot that the initial net device refcount was 0. When CONFIG_PCPU_DEV_REFCNT is not set, this means the first dev_hold() triggers an illegal refcount operation (addition on 0) refcount_t: addition on 0; use-after-free. WARNING: CPU: 0 P