Re: [PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-22 Thread Cong Wang
On Sun, Jul 21, 2019 at 7:44 AM Vlad Buslov wrote: > > In function int tc_new_tfilter() q pointer can be NULL when adding filter > on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after > filter creation, following NULL pointer dereference happens in case parent > block is shared

Re: [PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-21 Thread David Miller
From: Vlad Buslov Date: Sun, 21 Jul 2019 17:44:12 +0300 > In function int tc_new_tfilter() q pointer can be NULL when adding filter > on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after > filter creation, following NULL pointer dereference happens in case parent > block is sh

Re: [PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-21 Thread Jiri Pirko
Sun, Jul 21, 2019 at 04:44:12PM CEST, vla...@mellanox.com wrote: >In function int tc_new_tfilter() q pointer can be NULL when adding filter >on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after >filter creation, following NULL pointer dereference happens in case parent >block is

[PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-21 Thread Vlad Buslov
In function int tc_new_tfilter() q pointer can be NULL when adding filter on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after filter creation, following NULL pointer dereference happens in case parent block is shared: [ 212.925060] BUG: kernel NULL pointer dereference, addres