Re: [PATCH net-next] net: sched: shrink struct Qdisc

2018-05-28 Thread David Miller
From: Paolo Abeni Date: Fri, 25 May 2018 16:28:44 +0200 > The struct Qdisc has a lot of holes, especially after commit > a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback"), > which as a side effect, moved the fields just after 'busylock' > on a new cacheline. > > Since both 'padde

Re: [PATCH net-next] net: sched: shrink struct Qdisc

2018-05-25 Thread Jiri Pirko
Fri, May 25, 2018 at 04:28:44PM CEST, pab...@redhat.com wrote: >The struct Qdisc has a lot of holes, especially after commit >a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback"), >which as a side effect, moved the fields just after 'busylock' >on a new cacheline. > >Since both 'padded

[PATCH net-next] net: sched: shrink struct Qdisc

2018-05-25 Thread Paolo Abeni
The struct Qdisc has a lot of holes, especially after commit a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback"), which as a side effect, moved the fields just after 'busylock' on a new cacheline. Since both 'padded' and 'refcnt' are not updated frequently, and there is a hole before