Re: [PATCH net-next] net: sched: implement action-specific terse dump

2020-11-02 Thread Vlad Buslov
On Mon 02 Nov 2020 at 14:26, Jamal Hadi Salim wrote: > Thanks Vlad. Ive run the basic test and it looks good. > One thing i discovered while testing is that if the > cookie is set, we also want it in the dump. Your earlier > comment that it only costs if it was set is on point. > > So please remov

Re: [PATCH net-next] net: sched: implement action-specific terse dump

2020-11-02 Thread Jamal Hadi Salim
Thanks Vlad. Ive run the basic test and it looks good. One thing i discovered while testing is that if the cookie is set, we also want it in the dump. Your earlier comment that it only costs if it was set is on point. So please remove that check below: > + if (cookie && !from_act) { > +

[PATCH net-next] net: sched: implement action-specific terse dump

2020-10-31 Thread Vlad Buslov
Allow user to request action terse dump with new flag value TCA_FLAG_TERSE_DUMP. Only output essential action info in terse dump (kind, stats and index). This is different from filter terse dump where index is excluded (filter can be identified by its own handle) and cookie is included. Move tcf_a