Re: [PATCH net-next] net: sched: flower: use correct ht function to prevent duplicates

From: Jakub Kicinski Date: Thu, 11 Apr 2019 10:14:15 -0700 > On Thu, 11 Apr 2019 19:12:20 +0300, Vlad Buslov wrote: >> Implementation of function rhashtable_insert_fast() check if its internal >> helper function __rhashtable_insert_fast() returns non-NULL pointer and >> seemingly return -EEXIST i

Re: [PATCH net-next] net: sched: flower: use correct ht function to prevent duplicates

On Thu, 11 Apr 2019 19:12:20 +0300, Vlad Buslov wrote: > Implementation of function rhashtable_insert_fast() check if its internal > helper function __rhashtable_insert_fast() returns non-NULL pointer and > seemingly return -EEXIST in such case. However, since > __rhashtable_insert_fast() is called

[PATCH net-next] net: sched: flower: use correct ht function to prevent duplicates

Implementation of function rhashtable_insert_fast() check if its internal helper function __rhashtable_insert_fast() returns non-NULL pointer and seemingly return -EEXIST in such case. However, since __rhashtable_insert_fast() is called with NULL key pointer, it never actually checks for duplicates