Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-11 Thread Vlad Buslov
On Thu 11 Apr 2019 at 14:13, Ido Schimmel wrote: > On Fri, Apr 05, 2019 at 08:56:26PM +0300, Vlad Buslov wrote: >> John reports: >> >> Recent refactoring of fl_change aims to use the classifier spinlock to >> avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() >> function was mo

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-11 Thread Ido Schimmel
On Fri, Apr 05, 2019 at 08:56:26PM +0300, Vlad Buslov wrote: > John reports: > > Recent refactoring of fl_change aims to use the classifier spinlock to > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() > function was moved to before the lock is taken. This can create problems

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-10 Thread Jakub Kicinski
On Wed, 10 Apr 2019 16:26:38 +, Vlad Buslov wrote: > >> Actually, I intended to modify fl_reoffload() to ignore filters with > >> 'deleted' flag set when adding, but I guess reusing 'reoffload_count' to > >> retry fl_hw_destroy_filter() would also work. > > > > Yeah, I don't see how you can i

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-10 Thread Vlad Buslov
On Wed 10 Apr 2019 at 19:09, Jakub Kicinski wrote: > On Wed, 10 Apr 2019 16:02:17 +, Vlad Buslov wrote: >> On Wed 10 Apr 2019 at 18:48, Jakub Kicinski >> wrote: >> > On Wed, 10 Apr 2019 14:53:53 +, Vlad Buslov wrote: >> >> >> For my next patch set that unlocks the offloads API I implem

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-10 Thread Jakub Kicinski
On Wed, 10 Apr 2019 16:02:17 +, Vlad Buslov wrote: > On Wed 10 Apr 2019 at 18:48, Jakub Kicinski > wrote: > > On Wed, 10 Apr 2019 14:53:53 +, Vlad Buslov wrote: > >> >> For my next patch set that unlocks the offloads API I implemented the > >> >> algorithm to track reoffload count for e

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-10 Thread Vlad Buslov
On Wed 10 Apr 2019 at 18:48, Jakub Kicinski wrote: > On Wed, 10 Apr 2019 14:53:53 +, Vlad Buslov wrote: >> >> For my next patch set that unlocks the offloads API I implemented the >> >> algorithm to track reoffload count for each tp that works like this: >> >> >> >> 1. struct tcf_proto is ex

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-10 Thread Jakub Kicinski
On Wed, 10 Apr 2019 14:53:53 +, Vlad Buslov wrote: > >> For my next patch set that unlocks the offloads API I implemented the > >> algorithm to track reoffload count for each tp that works like this: > >> > >> 1. struct tcf_proto is extended with reoffload_count counter that > >>incremented

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-10 Thread Vlad Buslov
On Tue 09 Apr 2019 at 20:10, Jakub Kicinski wrote: > On Tue, 9 Apr 2019 08:23:40 +, Vlad Buslov wrote: >> On Tue 09 Apr 2019 at 01:26, Jakub Kicinski >> wrote: >> > On Fri, 5 Apr 2019 20:56:26 +0300, Vlad Buslov wrote: >> >> John reports: >> >> >> >> Recent refactoring of fl_change aims t

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-09 Thread Jakub Kicinski
On Tue, 9 Apr 2019 08:23:40 +, Vlad Buslov wrote: > On Tue 09 Apr 2019 at 01:26, Jakub Kicinski > wrote: > > On Fri, 5 Apr 2019 20:56:26 +0300, Vlad Buslov wrote: > >> John reports: > >> > >> Recent refactoring of fl_change aims to use the classifier spinlock to > >> avoid the need for rtn

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-09 Thread Vlad Buslov
On Tue 09 Apr 2019 at 01:26, Jakub Kicinski wrote: > On Fri, 5 Apr 2019 20:56:26 +0300, Vlad Buslov wrote: >> John reports: >> >> Recent refactoring of fl_change aims to use the classifier spinlock to >> avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() >> function was moved

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-08 Thread Jakub Kicinski
On Fri, 5 Apr 2019 20:56:26 +0300, Vlad Buslov wrote: > John reports: > > Recent refactoring of fl_change aims to use the classifier spinlock to > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() > function was moved to before the lock is taken. This can create problems > for

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-07 Thread David Miller
From: Vlad Buslov Date: Fri, 5 Apr 2019 20:56:26 +0300 > John reports: > > Recent refactoring of fl_change aims to use the classifier spinlock to > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() > function was moved to before the lock is taken. This can create problems > f

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-05 Thread Jiri Pirko
Fri, Apr 05, 2019 at 07:56:26PM CEST, vla...@mellanox.com wrote: >John reports: > >Recent refactoring of fl_change aims to use the classifier spinlock to >avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() >function was moved to before the lock is taken. This can create problems >

[PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-05 Thread Vlad Buslov
John reports: Recent refactoring of fl_change aims to use the classifier spinlock to avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() function was moved to before the lock is taken. This can create problems for drivers if duplicate filters are created (commmon in ovs tc offload