Re: [PATCH net-next] net: sched: avoid writing on noop_qdisc

2018-10-10 Thread David Miller
From: Eric Dumazet Date: Tue, 9 Oct 2018 15:20:50 -0700 > While noop_qdisc.gso_skb and noop_qdisc.skb_bad_txq are not used > in other places, it seems not correct to overwrite their fields > in dev_init_scheduler_queue(). > > noop_qdisc is essentially a shared and read-only object, even if > it

[PATCH net-next] net: sched: avoid writing on noop_qdisc

2018-10-09 Thread Eric Dumazet
While noop_qdisc.gso_skb and noop_qdisc.skb_bad_txq are not used in other places, it seems not correct to overwrite their fields in dev_init_scheduler_queue(). noop_qdisc is essentially a shared and read-only object, even if it is not marked as const because of some implementation detail. Signed-