Re: [PATCH net-next] net: sched: action_ife: take reference to meta module

2018-09-03 Thread Cong Wang
On Mon, Sep 3, 2018 at 12:10 AM Vlad Buslov wrote: > > Recent refactoring of add_metainfo() caused use_all_metadata() to add > metainfo to ife action metalist without taking reference to module. This > causes warning in module_put called from ife action cleanup function. > > Implement add_metainfo

Re: [PATCH net-next] net: sched: action_ife: take reference to meta module

2018-09-03 Thread Cong Wang
On Mon, Sep 3, 2018 at 10:12 AM Vlad Buslov wrote: > > > On Mon 03 Sep 2018 at 17:03, Cong Wang wrote: > > On Mon, Sep 3, 2018 at 12:10 AM Vlad Buslov wrote: > >> > >> Recent refactoring of add_metainfo() caused use_all_metadata() to add > >> metainfo to ife action metalist without taking refere

Re: [PATCH net-next] net: sched: action_ife: take reference to meta module

2018-09-03 Thread Vlad Buslov
On Mon 03 Sep 2018 at 17:03, Cong Wang wrote: > On Mon, Sep 3, 2018 at 12:10 AM Vlad Buslov wrote: >> >> Recent refactoring of add_metainfo() caused use_all_metadata() to add >> metainfo to ife action metalist without taking reference to module. This >> causes warning in module_put called from

Re: [PATCH net-next] net: sched: action_ife: take reference to meta module

2018-09-03 Thread Cong Wang
On Mon, Sep 3, 2018 at 12:10 AM Vlad Buslov wrote: > > Recent refactoring of add_metainfo() caused use_all_metadata() to add > metainfo to ife action metalist without taking reference to module. This > causes warning in module_put called from ife action cleanup function. > > Implement add_metainfo

[PATCH net-next] net: sched: action_ife: take reference to meta module

2018-09-03 Thread Vlad Buslov
Recent refactoring of add_metainfo() caused use_all_metadata() to add metainfo to ife action metalist without taking reference to module. This causes warning in module_put called from ife action cleanup function. Implement add_metainfo_and_get_ops() function that returns with reference to module t