Re: [PATCH net-next] net: sched: act_tunnel_key: fix metadata handling

2019-02-25 Thread Vlad Buslov
On Mon 25 Feb 2019 at 14:04, Davide Caratti wrote: > On Mon, 2019-02-25 at 14:21 +0200, Vlad Buslov wrote: >> Tunnel key action params->tcft_enc_metadata is only set when action is >> TCA_TUNNEL_KEY_ACT_SET. However, metadata pointer is incorrectly >> dereferenced during tunnel key init and rele

Re: [PATCH net-next] net: sched: act_tunnel_key: fix metadata handling

2019-02-25 Thread Davide Caratti
On Mon, 2019-02-25 at 14:21 +0200, Vlad Buslov wrote: > Tunnel key action params->tcft_enc_metadata is only set when action is > TCA_TUNNEL_KEY_ACT_SET. However, metadata pointer is incorrectly > dereferenced during tunnel key init and release without verifying that > action is if correct type, whi

[PATCH net-next] net: sched: act_tunnel_key: fix metadata handling

2019-02-25 Thread Vlad Buslov
Tunnel key action params->tcft_enc_metadata is only set when action is TCA_TUNNEL_KEY_ACT_SET. However, metadata pointer is incorrectly dereferenced during tunnel key init and release without verifying that action is if correct type, which causes NULL pointer dereference. Metadata tunnel dst_cache