Re: [PATCH net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-29 Thread Song Liu
> On May 29, 2018, at 1:58 AM, Sergei Shtylyov > wrote: > > Hello! > > On 5/29/2018 12:36 AM, Song Liu wrote: > >> Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed. > > "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make > much sense... Than

Re: [PATCH net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-29 Thread Sergei Shtylyov
Hello! On 5/29/2018 12:36 AM, Song Liu wrote: Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed. "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make much sense... This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK or NET

[PATCH net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-28 Thread Song Liu
Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed. This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 will reach the condition: if (ret && netif_xmit_frozen_or_stopped(txq)) return false;