Re: [PATCH net-next] net: propagate errors correctly in register_netdevice()

2019-10-03 Thread David Miller
From: Eric Dumazet Date: Thu, 3 Oct 2019 08:59:24 -0700 > If netdev_name_node_head_alloc() fails to allocate > memory, we absolutely want register_netdevice() to return > -ENOMEM instead of zero :/ > > One of the syzbot report looked like : > > general protection fault: [#1] PREEMPT SMP K

Re: [PATCH net-next] net: propagate errors correctly in register_netdevice()

2019-10-03 Thread Jiri Pirko
Thu, Oct 03, 2019 at 05:59:24PM CEST, eduma...@google.com wrote: >If netdev_name_node_head_alloc() fails to allocate >memory, we absolutely want register_netdevice() to return >-ENOMEM instead of zero :/ oops. > >One of the syzbot report looked like : > >general protection fault: [#1] PREEM

Re: [PATCH net-next] net: propagate errors correctly in register_netdevice()

2019-10-03 Thread Willem de Bruijn
On Thu, Oct 3, 2019 at 1:43 PM Eric Dumazet wrote: > > If netdev_name_node_head_alloc() fails to allocate > memory, we absolutely want register_netdevice() to return > -ENOMEM instead of zero :/ > > One of the syzbot report looked like : > > general protection fault: [#1] PREEMPT SMP KASAN >

[PATCH net-next] net: propagate errors correctly in register_netdevice()

2019-10-03 Thread Eric Dumazet
If netdev_name_node_head_alloc() fails to allocate memory, we absolutely want register_netdevice() to return -ENOMEM instead of zero :/ One of the syzbot report looked like : general protection fault: [#1] PREEMPT SMP KASAN CPU: 1 PID: 8760 Comm: syz-executor839 Not tainted 5.3.0+ #0 Hardwar