Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-10 Thread Florian Fainelli
On 4/10/2019 12:31 PM, Heiner Kallweit wrote: > On 09.04.2019 22:59, David Miller wrote: >> From: Heiner Kallweit >> Date: Sun, 7 Apr 2019 11:57:13 +0200 >> >>> Recently genphy_read_abilities() has been added that dynamically detects >>> clause 22 PHY abilities. I *think* this detection should

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-10 Thread Heiner Kallweit
On 09.04.2019 22:59, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 7 Apr 2019 11:57:13 +0200 > >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-09 Thread David Miller
From: Heiner Kallweit Date: Sun, 7 Apr 2019 11:57:13 +0200 > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATUR

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-08 Thread Heiner Kallweit
On 08.04.2019 20:12, Andrew Lunn wrote: >> Splitting the series and waiting for a Tested-by, as proposed by Richard, >> may be problematic because most PHY drivers don't have a dedicated >> maintainer, and we lack the hardware to test. > > Well, we could split out those we know are likely to get t

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-08 Thread Andrew Lunn
> Splitting the series and waiting for a Tested-by, as proposed by Richard, > may be problematic because most PHY drivers don't have a dedicated > maintainer, and we lack the hardware to test. Well, we could split out those we know are likely to get tested. I have a number of boards with Marvell

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-08 Thread Heiner Kallweit
On 08.04.2019 00:13, Andrew Lunn wrote: > On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Richard Cochran
On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all Famous last words! > supported PHY's, at least for the ones with basic features sets

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Andrew Lunn
On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FE

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Heiner Kallweit
On 07.04.2019 22:31, Florian Fainelli wrote: > > > On 4/7/2019 2:57 AM, Heiner Kallweit wrote: >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones with basic

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Florian Fainelli
On 4/7/2019 2:57 AM, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBI

[PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Heiner Kallweit
Recently genphy_read_abilities() has been added that dynamically detects clause 22 PHY abilities. I *think* this detection should work with all supported PHY's, at least for the ones with basic features sets, i.e. PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these features expl