Re: [PATCH net-next] net: phy: improve stopping PHY

2019-01-16 Thread Heiner Kallweit
On 16.01.2019 20:40, Andrew Lunn wrote: > On Wed, Jan 16, 2019 at 08:20:43PM +0100, Heiner Kallweit wrote: >> phy_stop_interrupts() is called from phy_disconnect() only. Most of >> what it does has been done by phy_stop() already which should have >> been called before phy_disconnect(). Based on th

Re: [PATCH net-next] net: phy: improve stopping PHY

2019-01-16 Thread Andrew Lunn
On Wed, Jan 16, 2019 at 08:20:43PM +0100, Heiner Kallweit wrote: > phy_stop_interrupts() is called from phy_disconnect() only. Most of > what it does has been done by phy_stop() already which should have > been called before phy_disconnect(). Based on that we can do some > improvements: > - remove

[PATCH net-next] net: phy: improve stopping PHY

2019-01-16 Thread Heiner Kallweit
phy_stop_interrupts() is called from phy_disconnect() only. Most of what it does has been done by phy_stop() already which should have been called before phy_disconnect(). Based on that we can do some improvements: - remove phy_stop_interrupts() and free interrupt in phy_disconnect() directly - r