Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-25 Thread Heiner Kallweit
On 19.04.2019 01:30, David Miller wrote: > From: Heiner Kallweit > Date: Wed, 17 Apr 2019 00:06:28 +0200 > >> This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be >> able to remove this predefined feature constant later. Setting >> phydev->advertising to what is supported is done

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-18 Thread David Miller
From: Heiner Kallweit Date: Wed, 17 Apr 2019 00:06:28 +0200 > This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be > able to remove this predefined feature constant later. Setting > phydev->advertising to what is supported is done by phy_probe(), > therefore we don't have to do i

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Florian Fainelli
On 16/04/2019 15:34, Heiner Kallweit wrote: On 17.04.2019 00:25, Andrew Lunn wrote: @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { .phy_id = PHY_ID_BCM8706, .phy_id_mask= 0x, .name = "Broadcom BCM8706", - .features

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Heiner Kallweit
On 17.04.2019 00:25, Andrew Lunn wrote: >> @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { >> .phy_id = PHY_ID_BCM8706, >> .phy_id_mask= 0x, >> .name = "Broadcom BCM8706", >> -.features = PHY_10GBIT_FEC_FEATURES, >> +.get_

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Andrew Lunn
> @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { > .phy_id = PHY_ID_BCM8706, > .phy_id_mask= 0x, > .name = "Broadcom BCM8706", > - .features = PHY_10GBIT_FEC_FEATURES, > + .get_features = bcm87xx_get_features, >

[PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Heiner Kallweit
This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be able to remove this predefined feature constant later. Setting phydev->advertising to what is supported is done by phy_probe(), therefore we don't have to do it in the config_init callback. Resetting phydev->autoneg if autoneg is