Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-02-01 Thread Willem de Bruijn
On Mon, Feb 1, 2021 at 3:55 PM Jakub Kicinski wrote: > > On Mon, 1 Feb 2021 13:33:05 -0500 Willem de Bruijn wrote: > > On Mon, Feb 1, 2021 at 11:41 AM Loic Poulain > > wrote: > > > On Mon, 1 Feb 2021 at 15:24, Willem de Bruijn wrote: > > > > What is this path to rmnet, if not the usual xmit path

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-02-01 Thread Jakub Kicinski
On Mon, 1 Feb 2021 13:33:05 -0500 Willem de Bruijn wrote: > On Mon, Feb 1, 2021 at 11:41 AM Loic Poulain wrote: > > On Mon, 1 Feb 2021 at 15:24, Willem de Bruijn wrote: > > > What is this path to rmnet, if not the usual xmit path / > > > validate_xmit_skb? > > > > I mean, not sure what to do

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-02-01 Thread Willem de Bruijn
On Mon, Feb 1, 2021 at 11:41 AM Loic Poulain wrote: > > On Mon, 1 Feb 2021 at 15:24, Willem de Bruijn > wrote: > > > > On Mon, Feb 1, 2021 at 3:08 AM Loic Poulain wrote: > > > > > > Hi Jakub, Willem, > > > > > > On Sat, 30 Jan 2021 at 02:01, Jakub Kicinski wrote: > > > > > > > > On Mon, 25 Jan

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-02-01 Thread Loic Poulain
On Mon, 1 Feb 2021 at 15:24, Willem de Bruijn wrote: > > On Mon, Feb 1, 2021 at 3:08 AM Loic Poulain wrote: > > > > Hi Jakub, Willem, > > > > On Sat, 30 Jan 2021 at 02:01, Jakub Kicinski wrote: > > > > > > On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote: > > > > When device side MTU is lar

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-02-01 Thread Willem de Bruijn
On Mon, Feb 1, 2021 at 3:08 AM Loic Poulain wrote: > > Hi Jakub, Willem, > > On Sat, 30 Jan 2021 at 02:01, Jakub Kicinski wrote: > > > > On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote: > > > When device side MTU is larger than host side MRU, the packets > > > (typically rmnet packets) are

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-02-01 Thread Loic Poulain
Hi Jakub, Willem, On Sat, 30 Jan 2021 at 02:01, Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote: > > When device side MTU is larger than host side MRU, the packets > > (typically rmnet packets) are split over multiple MHI transfers. > > In that case, fragments must

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-01-29 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 8:01 PM Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote: > > When device side MTU is larger than host side MRU, the packets > > (typically rmnet packets) are split over multiple MHI transfers. > > In that case, fragments must be re-aggregated

Re: [PATCH net-next] net: mhi-net: Add de-aggeration support

2021-01-29 Thread Jakub Kicinski
On Mon, 25 Jan 2021 16:45:57 +0100 Loic Poulain wrote: > When device side MTU is larger than host side MRU, the packets > (typically rmnet packets) are split over multiple MHI transfers. > In that case, fragments must be re-aggregated to recover the packet > before forwarding to upper layer. > > A

[PATCH net-next] net: mhi-net: Add de-aggeration support

2021-01-26 Thread Loic Poulain
When device side MTU is larger than host side MRU, the packets (typically rmnet packets) are split over multiple MHI transfers. In that case, fragments must be re-aggregated to recover the packet before forwarding to upper layer. A fragmented packet result in -EOVERFLOW MHI transaction status for