Re: [PATCH net-next] net: ipv6: Check that idev is non-NULL in rt6_fill_node

2017-01-22 Thread David Ahern
On 1/22/17 9:32 PM, David Miller wrote: > From: David Ahern > Date: Sun, 22 Jan 2017 20:08:00 -0800 > >> The ipv6 route dump code passes ip6_null_entry to rt6_fill_node. > > Doesn't this fact cause you to take a pause? yes, it did. > > I can't see a legitimate reason to dump the null entry, i

Re: [PATCH net-next] net: ipv6: Check that idev is non-NULL in rt6_fill_node

2017-01-22 Thread David Miller
From: David Ahern Date: Sun, 22 Jan 2017 20:08:00 -0800 > The ipv6 route dump code passes ip6_null_entry to rt6_fill_node. Doesn't this fact cause you to take a pause? I can't see a legitimate reason to dump the null entry, it's a marker rather than a real entry.

[PATCH net-next] net: ipv6: Check that idev is non-NULL in rt6_fill_node

2017-01-22 Thread David Ahern
lkp-robot reported a BUG: [ 10.151226] BUG: unable to handle kernel NULL pointer dereference at 0198 [ 10.152525] IP: rt6_fill_node+0x164/0x4b8 [ 10.153307] *pdpt = 12ee5001 *pde = [ 10.153309] [ 10.154492] Oops: [#1] [ 10.154987] CPU: 0 PID: 909 Comm: