Re: [PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

2021-03-22 Thread Vladimir Oltean
Hi Heiko, On Mon, Mar 22, 2021 at 11:57:33AM +0100, Heiko Thiery wrote: > Hi Vladimir and all, > > > Due to the fact that ic_dev->dev is kept open in ic_close_dev, I had > > thought that ic_dev will not be freed either. But that is not the case, > > but instead "everybody dies" when ipconfig clea

Re: [PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

2021-03-22 Thread Heiko Thiery
Hi Vladimir and all, > Due to the fact that ic_dev->dev is kept open in ic_close_dev, I had > thought that ic_dev will not be freed either. But that is not the case, > but instead "everybody dies" when ipconfig cleans up, and just the > net_device behind ic_dev->dev remains allocated but not ic_de

Re: [PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 01:57:03 +0200 you wrote: > From: Vladimir Oltean > > Due to the fact that ic_dev->dev is kept open in ic_close_dev, I had > thought that ic_dev will not be freed either. But that is not the case, > bu

Re: [PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

2021-02-10 Thread Florian Fainelli
On 2/10/2021 3:57 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Due to the fact that ic_dev->dev is kept open in ic_close_dev, I had > thought that ic_dev will not be freed either. But that is not the case, > but instead "everybody dies" when ipconfig cleans up, and just the > net_dev

[PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

2021-02-10 Thread Vladimir Oltean
From: Vladimir Oltean Due to the fact that ic_dev->dev is kept open in ic_close_dev, I had thought that ic_dev will not be freed either. But that is not the case, but instead "everybody dies" when ipconfig cleans up, and just the net_device behind ic_dev->dev remains allocated but not ic_dev itse