RE: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread Haiyang Zhang
t;> To: Haiyang Zhang > >> Cc: eric.duma...@gmail.com; KY Srinivasan ; > >> eduma...@google.com; netdev@vger.kernel.org > >> Subject: Re: [PATCH net-next] net: increase LL_MAX_HEADER if > >> HYPERV_NET is enabled > >> > >> From: Haiyang Zhang

Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread David Miller
.@google.com; netdev@vger.kernel.org >> Subject: Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET >> is enabled >> >> From: Haiyang Zhang >> Date: Tue, 3 Nov 2015 17:34:47 + >> >> > But we still keep this busy return in our code

RE: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread Haiyang Zhang
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, November 3, 2015 1:20 PM > To: Haiyang Zhang > Cc: eric.duma...@gmail.com; KY Srinivasan ; > eduma...@google.com; netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: incr

Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread David Miller
From: Haiyang Zhang Date: Tue, 3 Nov 2015 17:34:47 + > But we still keep this busy return in our code, just for "weird corner cases". The queue_stopped condition must be precise. If you cannot enqueue a maximally segmented SKB, you must stop the queue. -- To unsubscribe from this list: send

RE: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread KY Srinivasan
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, November 3, 2015 7:33 AM > To: KY Srinivasan > Cc: eric.duma...@gmail.com; Haiyang Zhang ; > eduma...@google.com; netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: incr

RE: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread Haiyang Zhang
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Tuesday, November 3, 2015 11:37 AM > To: David Miller > Cc: KY Srinivasan ; Haiyang Zhang > ; eduma...@google.com; > netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: i

Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread Eric Dumazet
On Tue, 2015-11-03 at 10:33 -0500, David Miller wrote: > From: KY Srinivasan > Date: Tue, 3 Nov 2015 07:59:36 + > > > I have implemented the scheme we had discussed a few weeks ago. In > > this new implementation our driver is NOT requesting addition > > headroom - rndis header and the per pa

Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread David Miller
From: KY Srinivasan Date: Tue, 3 Nov 2015 07:59:36 + > I have implemented the scheme we had discussed a few weeks ago. In > this new implementation our driver is NOT requesting addition > headroom - rndis header and the per packet state is being maintained > outside of the skb. What I am seei

RE: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-03 Thread KY Srinivasan
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Sunday, November 1, 2015 12:59 PM > To: eric.duma...@gmail.com > Cc: Haiyang Zhang ; eduma...@google.com; > netdev@vger.kernel.org; KY Srinivasan > Subject: Re: [PATCH net-next] net: incr

Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-01 Thread Eric Dumazet
On Sun, 2015-11-01 at 15:58 -0500, David Miller wrote: > From: Eric Dumazet > Date: Sun, 01 Nov 2015 09:20:59 -0800 > > > From: Eric Dumazet > > > > My recent commit, attaching SYNACK messages to request sockets > > exposed a too small LL_MAX_HEADER when netvsc_drv.c is in use, > > because this

Re: [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-01 Thread David Miller
From: Eric Dumazet Date: Sun, 01 Nov 2015 09:20:59 -0800 > From: Eric Dumazet > > My recent commit, attaching SYNACK messages to request sockets > exposed a too small LL_MAX_HEADER when netvsc_drv.c is in use, > because this driver sets a needed_headroom of 220 bytes. > > Increase LL_MAX_HEADE

[PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled

2015-11-01 Thread Eric Dumazet
From: Eric Dumazet My recent commit, attaching SYNACK messages to request sockets exposed a too small LL_MAX_HEADER when netvsc_drv.c is in use, because this driver sets a needed_headroom of 220 bytes. Increase LL_MAX_HEADER in this case, to avoid a realloc of all TCP frames. In another patch,