Re: [PATCH net-next] net: filter: remove unused variable and fix warning

2017-10-30 Thread David Miller
From: Jakub Kicinski Date: Mon, 30 Oct 2017 13:46:47 -0700 > bpf_getsockopt bpf call sets the ret variable to zero and > never changes it. What's worse in case CONFIG_INET is > not selected the variable is completely unused generating > a warning. > > Signed-off-by: Jakub Kicinski > Reviewed-b

Re: [PATCH net-next] net: filter: remove unused variable and fix warning

2017-10-30 Thread Alexei Starovoitov
On Mon, Oct 30, 2017 at 01:46:47PM -0700, Jakub Kicinski wrote: > bpf_getsockopt bpf call sets the ret variable to zero and > never changes it. What's worse in case CONFIG_INET is > not selected the variable is completely unused generating > a warning. > > Signed-off-by: Jakub Kicinski > Reviewe

Re: [PATCH net-next] net: filter: remove unused variable and fix warning

2017-10-30 Thread Daniel Borkmann
On 10/30/2017 09:46 PM, Jakub Kicinski wrote: bpf_getsockopt bpf call sets the ret variable to zero and never changes it. What's worse in case CONFIG_INET is not selected the variable is completely unused generating a warning. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-

Re: [PATCH net-next] net: filter: remove unused variable and fix warning

2017-10-30 Thread Lawrence Brakmo
Good catch, thanks! On 10/30/17, 1:47 PM, "Jakub Kicinski" wrote: bpf_getsockopt bpf call sets the ret variable to zero and never changes it. What's worse in case CONFIG_INET is not selected the variable is completely unused generating a warning. Signed-off-by: Jakub Ki

[PATCH net-next] net: filter: remove unused variable and fix warning

2017-10-30 Thread Jakub Kicinski
bpf_getsockopt bpf call sets the ret variable to zero and never changes it. What's worse in case CONFIG_INET is not selected the variable is completely unused generating a warning. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- net/core/filter.c | 3 +-- 1 file changed, 1 insert