Re: [PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing

2018-04-23 Thread David Ahern
On 4/23/18 9:21 PM, David Miller wrote: > From: Roopa Prabhu > Date: Mon, 23 Apr 2018 20:08:41 -0700 > >> From: Roopa Prabhu >> >> Fixes: b16fb418b1bf ("net: fib_rules: add extack support") >> Signed-off-by: Roopa Prabhu > > Applied. > > It would be nice to get rid of these if() conditionals

Re: [PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing

2018-04-23 Thread David Miller
From: Roopa Prabhu Date: Mon, 23 Apr 2018 20:08:41 -0700 > From: Roopa Prabhu > > Fixes: b16fb418b1bf ("net: fib_rules: add extack support") > Signed-off-by: Roopa Prabhu Applied. It would be nice to get rid of these if() conditionals dangling around ifdef blocks. They are quite error prone

[PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing

2018-04-23 Thread Roopa Prabhu
From: Roopa Prabhu Fixes: b16fb418b1bf ("net: fib_rules: add extack support") Signed-off-by: Roopa Prabhu --- Looks like I broke this when i split extack changes into a separate patch :( net/core/fib_rules.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/fib_rules.c b/net/core/