Re: [EXT] Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-29 Thread David Miller
From: Andrew Lunn Date: Wed, 29 Apr 2020 16:11:02 +0200 >> > >> Applied to net-next, thanks. >> > > >> > > David, it is too early to apply the patch, it will introduce another >> > > break issue as I explain in previous mail for the patch. >> > >> > So what should I do, revert? >> >> If you can

Re: [EXT] Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-29 Thread Andrew Lunn
> > >> Applied to net-next, thanks. > > > > > > David, it is too early to apply the patch, it will introduce another > > > break issue as I explain in previous mail for the patch. > > > > So what should I do, revert? > > If you can revert the patch, please do it. > Thanks, David. Hi David Plea

RE: [EXT] Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread Andy Duan
From: David Miller Sent: Wednesday, April 29, 2020 11:35 AM > From: Andy Duan > Date: Wed, 29 Apr 2020 01:55:35 + > > > From: David Miller Sent: Wednesday, April 29, > > 2020 5:34 AM > >> From: Andrew Lunn > >> Date: Tue, 28 Apr 2020 19:58:33 +0200 > >> > >> > The change to polled IO for

Re: [EXT] Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread David Miller
From: Andy Duan Date: Wed, 29 Apr 2020 01:55:35 + > From: David Miller Sent: Wednesday, April 29, 2020 5:34 > AM >> From: Andrew Lunn >> Date: Tue, 28 Apr 2020 19:58:33 +0200 >> >> > The change to polled IO for MDIO completion assumes that MII events >> > are only generated for MDIO trans

RE: [EXT] Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread Andy Duan
From: David Miller Sent: Wednesday, April 29, 2020 5:34 AM > From: Andrew Lunn > Date: Tue, 28 Apr 2020 19:58:33 +0200 > > > The change to polled IO for MDIO completion assumes that MII events > > are only generated for MDIO transactions. However on some SoCs writing > > to the MII_SPEED registe

RE: [EXT] [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread Andy Duan
From: Andrew Lunn Sent: Wednesday, April 29, 2020 1:59 AM > The change to polled IO for MDIO completion assumes that MII events are > only generated for MDIO transactions. However on some SoCs writing to the > MII_SPEED register can also trigger an MII event. As a result, the next MDIO > read has

RE: [EXT] Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread Andy Duan
From: Andrew Lunn Sent: Wednesday, April 29, 2020 2:02 AM > On Tue, Apr 28, 2020 at 07:58:33PM +0200, Andrew Lunn wrote: > > The change to polled IO for MDIO completion assumes that MII events > > are only generated for MDIO transactions. However on some SoCs writing > > to the MII_SPEED register

Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread David Miller
From: Andrew Lunn Date: Tue, 28 Apr 2020 19:58:33 +0200 > The change to polled IO for MDIO completion assumes that MII events > are only generated for MDIO transactions. However on some SoCs writing > to the MII_SPEED register can also trigger an MII event. As a result, > the next MDIO read has a

[PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread Andrew Lunn
The change to polled IO for MDIO completion assumes that MII events are only generated for MDIO transactions. However on some SoCs writing to the MII_SPEED register can also trigger an MII event. As a result, the next MDIO read has a pending MII event, and immediately reads the data registers befor

Re: [PATCH net-next] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-04-28 Thread Andrew Lunn
On Tue, Apr 28, 2020 at 07:58:33PM +0200, Andrew Lunn wrote: > The change to polled IO for MDIO completion assumes that MII events > are only generated for MDIO transactions. However on some SoCs writing > to the MII_SPEED register can also trigger an MII event. As a result, > the next MDIO read ha