Re: [PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-11 Thread Jakub Kicinski
On Thu, 12 Nov 2020 00:49:03 +0100 Tobias Waldekranz wrote: > > I'm unclear what this fixes. What functionality is broken on 6097? > > VLAN configuration. As soon as you add the second port to a VLAN, all > other port membership configuration is overwritten with zeroes. The HW > interprets this

Re: [PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-11 Thread Jakub Kicinski
On Sun, 8 Nov 2020 23:38:10 +0100 Tobias Waldekranz wrote: > On the 6352, doing a VTU GetNext op, followed by an STU GetNext op > will leave you with both the member- and state- data in the VTU/STU > data registers. But on the 6097 (which uses the same implementation), > the STU GetNext will overr

Re: [PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-11 Thread Tobias Waldekranz
On Wed Nov 11, 2020 at 4:27 PM CET, Jakub Kicinski wrote: > On Sun, 8 Nov 2020 23:38:10 +0100 Tobias Waldekranz wrote: > > On the 6352, doing a VTU GetNext op, followed by an STU GetNext op > > will leave you with both the member- and state- data in the VTU/STU > > data registers. But on the 6097 (

[PATCH net-next] net: dsa: mv88e6xxx: 6352: parse VTU data before loading STU data

2020-11-08 Thread Tobias Waldekranz
On the 6352, doing a VTU GetNext op, followed by an STU GetNext op will leave you with both the member- and state- data in the VTU/STU data registers. But on the 6097 (which uses the same implementation), the STU GetNext will override the information gathered from the VTU GetNext. Separate the two