Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported

2020-09-07 Thread Jakub Kicinski
On Tue, 8 Sep 2020 02:25:56 +0300 Vladimir Oltean wrote: > Commit 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set > the MTU") changed, for some reason, the "err && err != -EOPNOTSUPP" > check into a simple "err". This causes the MTU warning to be printed > even for drivers that don

Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported

2020-09-07 Thread Florian Fainelli
On 9/7/2020 4:25 PM, Vladimir Oltean wrote: Commit 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU") changed, for some reason, the "err && err != -EOPNOTSUPP" check into a simple "err". This causes the MTU warning to be printed even for drivers that don't have the MTU o

Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported

2020-09-07 Thread Vladimir Oltean
On Tue, Sep 08, 2020 at 02:57:09AM +0200, Andrew Lunn wrote: > Hi Vladimir > > In some ways, this has been good. A lot more DSA drivers now have MTU > support and jumbo packet support. Yes, I suspect this is because many people wanted to experiment with jumbo frames anyway, and the warning in dmes

Re: [PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported

2020-09-07 Thread Andrew Lunn
On Tue, Sep 08, 2020 at 02:25:56AM +0300, Vladimir Oltean wrote: > Commit 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set > the MTU") changed, for some reason, the "err && err != -EOPNOTSUPP" > check into a simple "err". This causes the MTU warning to be printed > even for drivers t

[PATCH net-next] net: dsa: don't print non-fatal MTU error if not supported

2020-09-07 Thread Vladimir Oltean
Commit 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU") changed, for some reason, the "err && err != -EOPNOTSUPP" check into a simple "err". This causes the MTU warning to be printed even for drivers that don't have the MTU operations implemented. Fix that. Signed-off-by: