Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-12 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +#ifdef CONFIG_NET_DSA_LEGACY >> static const char *mv88e6xxx_drv_probe(struct device *dsa_dev, >> struct device *host_dev, int sw_addr, >> void **priv) >> @@ -4256,6 +4257,7 @@ static cons

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-12 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > On 04/11/2017 01:52 PM, Vivien Didelot wrote: >> This patch moves as is the legacy DSA code from dsa.c to legacy.c, >> except the few shared symbols which remain in dsa.c. >> >> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, >> whi

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-11 Thread Andrew Lunn
> +#ifdef CONFIG_NET_DSA_LEGACY > static const char *mv88e6xxx_drv_probe(struct device *dsa_dev, > struct device *host_dev, int sw_addr, > void **priv) > @@ -4256,6 +4257,7 @@ static const char *mv88e6xxx_drv_probe(struct de

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-11 Thread Florian Fainelli
On 04/11/2017 01:52 PM, Vivien Didelot wrote: > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, > which is true by default. > > DSA drivers without

[PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2017-04-11 Thread Vivien Didelot
This patch moves as is the legacy DSA code from dsa.c to legacy.c, except the few shared symbols which remain in dsa.c. Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, which is true by default. DSA drivers without legacy support don't need the probe function as well as dri

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-21 Thread Andrew Lunn
On Thu, Jul 21, 2016 at 10:46:56AM -0400, Vivien Didelot wrote: > Florian Fainelli writes: > > > Le 20/07/2016 à 17:35, Andrew Lunn a écrit : > >> On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: > >>> This patch simply moves the legacy DSA code from dsa.c to legacy.c, > >>> except

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-21 Thread Vivien Didelot
Florian Fainelli writes: > Le 20/07/2016 à 17:35, Andrew Lunn a écrit : >> On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: >>> This patch simply moves the legacy DSA code from dsa.c to legacy.c, >>> except the few shared symbols which remain in dsa.c. >> >> I think it is a bit ea

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-21 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> net/dsa/dsa.c| 985 >> net/dsa/legacy.c | 1013 >> ++ > > I'm surprised git did not notice this is a rename. I used -M though, even -C doesn't change

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Florian Fainelli
Le 20/07/2016 à 17:35, Andrew Lunn a écrit : > On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: >> This patch simply moves the legacy DSA code from dsa.c to legacy.c, >> except the few shared symbols which remain in dsa.c. > > I think it is a bit early for this. Lets convert all in

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: > This patch simply moves the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. I think it is a bit early for this. Lets convert all in kernel users to the new binding first. > Signed-off-

[PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Vivien Didelot
This patch simply moves the legacy DSA code from dsa.c to legacy.c, except the few shared symbols which remain in dsa.c. Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, which is true by default. DSA drivers without legacy support don't need the probe function as well as dr