Re: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-31 Thread David Miller
From: yuan linyu Date: Sun, 29 Oct 2017 09:48:44 +0800 > From: yuan linyu > > Signed-off-by: yuan linyu Please compile test your patches and watch for warnings: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function ‘dpaa_eth_probe’: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2671:2

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-30 Thread Madalin-cristian Bucur
dalin.bu...@nxp.com] > > > Sent: Monday, October 30, 2017 1:56 PM > > > To: Yuan, Linyu (NSB - CN/Shanghai); yuan linyu; > netdev@vger.kernel.org; > > > gre...@linuxfoundation.org > > > Cc: David S . Miller > > > Subject: RE: [PATCH net-next] net: dpaa: remove in

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-30 Thread Madalin-cristian Bucur
> > gre...@linuxfoundation.org > > Cc: David S . Miller > > Subject: RE: [PATCH net-next] net: dpaa: remove init which already done > in > > per-cpu allocation > > > > Also here: > > > > > > http://elixir.free-electrons.com/l

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-29 Thread Yuan, Linyu (NSB - CN/Shanghai)
vid S . Miller > Subject: RE: [PATCH net-next] net: dpaa: remove init which already done in > per-cpu allocation > > Also here: > > http://elixir.free-electrons.com/linux/latest/source/mm/percpu.c#L717 > > Should the fact that the memory is zeroed be included in the function

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-29 Thread Madalin-cristian Bucur
ay, October 30, 2017 7:21 AM > To: Madalin-cristian Bucur ; yuan linyu > ; netdev@vger.kernel.org > Cc: David S . Miller > Subject: RE: [PATCH net-next] net: dpaa: remove init which already done in > per-cpu allocation > > http://elixir.free-electrons.com/linux/latest/source/mm/

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-29 Thread Yuan, Linyu (NSB - CN/Shanghai)
. Miller; Yuan, Linyu (NSB - CN/Shanghai) > Subject: RE: [PATCH net-next] net: dpaa: remove init which already done in > per-cpu allocation > > Hi Yuan, > > Can you please give more details about this change you are proposing? > > Regards, > Madalin > >

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-29 Thread Yuan, Linyu (NSB - CN/Shanghai)
gt; Cc: David S . Miller > Subject: RE: [PATCH net-next] net: dpaa: remove init which already done in > per-cpu allocation > > Is the memset part documented? > Can you point to the specific comment & code that does it? > > Thanks > > > -Original Mess

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-29 Thread Madalin-cristian Bucur
linyu > ; netdev@vger.kernel.org > Cc: David S . Miller > Subject: RE: [PATCH net-next] net: dpaa: remove init which already done in > per-cpu allocation > > Hi, > > devm_alloc_percpu() will allocate per-cpu memory and memset allocated > block content to 0. > &g

RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-29 Thread Madalin-cristian Bucur
vger.kernel.org > Cc: David S . Miller ; yuan linyu > > Subject: [PATCH net-next] net: dpaa: remove init which already done in > per-cpu allocation > > From: yuan linyu > > Signed-off-by: yuan linyu > --- > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ---

[PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-28 Thread yuan linyu
From: yuan linyu Signed-off-by: yuan linyu --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index a8d0be8..1ccc316 100644 --- a/drivers/net/e