Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-11-02 Thread Willem de Bruijn
On Sat, Oct 31, 2020 at 11:56 AM Alexander Lobakin wrote: > > From: Willem de Bruijn > Date: Sat, 31 Oct 2020 11:26:24 -0400 > > I think it is fine to reenable this again, now that UDP sockets will > segment unexpected UDP GSO packets that may have looped. We previously > added gen

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Willem de Bruijn Date: Sat, 31 Oct 2020 11:26:24 -0400 I think it is fine to reenable this again, now that UDP sockets will segment unexpected UDP GSO packets that may have looped. We previously added general software support in commit 83aa025f535f ("udp: add gso support

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Alexander Lobakin Date: Sat, 31 Oct 2020 14:17:03 + > From: Alexander Lobakin > Date: Sat, 31 Oct 2020 10:31:31 + > >> On Saturday, 31 October 2020, 2:12, Willem de Bruijn >> wrote: >> >> Hi Willem, >> >>> On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: >>

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Willem de Bruijn
> >> I think it is fine to reenable this again, now that UDP sockets will > >> segment unexpected UDP GSO packets that may have looped. We previously > >> added general software support in commit 83aa025f535f ("udp: add gso > >> support to virtual devices"). Then reduced its scope to egress only in

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Willem de Bruijn
On Sat, Oct 31, 2020 at 6:31 AM Alexander Lobakin wrote: > > On Saturday, 31 October 2020, 2:12, Willem de Bruijn > wrote: > > Hi Willem, > > > On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: > > > > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a sup

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
From: Alexander Lobakin Date: Sat, 31 Oct 2020 10:31:31 + > On Saturday, 31 October 2020, 2:12, Willem de Bruijn > wrote: > > Hi Willem, > >> On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: >> >>> Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a sup

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-31 Thread Alexander Lobakin
On Saturday, 31 October 2020, 2:12, Willem de Bruijn wrote: Hi Willem, > On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin aloba...@pm.me wrote: > > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support > > for fraglist UDP L4 and fraglist GSO not only for local traffic,

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin wrote: > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support > for fraglist UDP L4 and fraglist GSO not only for local traffic, but also > for forwarding. This works well on simple setups, but when any logical > netdev (e.g

[PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-30 Thread Alexander Lobakin
Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support for fraglist UDP L4 and fraglist GSO not only for local traffic, but also for forwarding. This works well on simple setups, but when any logical netdev (e.g. VLAN) is present, kernel stack always performs software resegmenta