Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-15 Thread Cambda Zhu
> On Dec 15, 2020, at 19:06, Eric Dumazet wrote: > > On Tue, Dec 15, 2020 at 3:08 AM Jakub Kicinski wrote: >> >> On Sun, 13 Dec 2020 21:59:45 +0800 Cambda Zhu wrote: On Dec 13, 2020, at 06:32, Jakub Kicinski wrote: On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > For each

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-14 Thread Jakub Kicinski
On Sun, 13 Dec 2020 21:59:45 +0800 Cambda Zhu wrote: > > On Dec 13, 2020, at 06:32, Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > >> For each TCP zero window probe, the icsk_backoff is increased by one and > >> its max value is tcp_retries2. If tcp_retries2 is

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-13 Thread Cambda Zhu
> On Dec 13, 2020, at 06:32, Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: >> For each TCP zero window probe, the icsk_backoff is increased by one and >> its max value is tcp_retries2. If tcp_retries2 is greater than 63, the >> probe0 timeout shift may exceed it

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > For each TCP zero window probe, the icsk_backoff is increased by one and > its max value is tcp_retries2. If tcp_retries2 is greater than 63, the > probe0 timeout shift may exceed its max bits. On x86_64/ARMv8/MIPS, the > shift count would be m

[PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-08 Thread Cambda Zhu
For each TCP zero window probe, the icsk_backoff is increased by one and its max value is tcp_retries2. If tcp_retries2 is greater than 63, the probe0 timeout shift may exceed its max bits. On x86_64/ARMv8/MIPS, the shift count would be masked to range 0 to 63. And on ARMv7 the result is zero. If t