Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-23 Thread Yafang Shao
On Sat, Dec 23, 2017 at 5:42 PM, Sergei Shtylyov wrote: > On 12/23/2017 4:10 AM, Yafang Shao wrote: > There's a space character missed in the printk messages. This error should be prevented with checkscript.pl, but it couldn't caught > > >> It is checkpatch.pl. > > >Yes, that to

Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-23 Thread Sergei Shtylyov
On 12/23/2017 4:10 AM, Yafang Shao wrote: There's a space character missed in the printk messages. This error should be prevented with checkscript.pl, but it couldn't caught It is checkpatch.pl. Yes, that too. But I actually meant you missed "be" between "couldn't" and "caught"... by

Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-22 Thread Yafang Shao
On Sat, Dec 23, 2017 at 9:10 AM, Yafang Shao wrote: > On Sat, Dec 23, 2017 at 1:04 AM, Sergei Shtylyov > wrote: >> Hello! >> >> On 12/22/2017 06:37 PM, Yafang Shao wrote: >> >>> There's a space character missed in the printk messages. >>> This error should be prevented with checkscript.pl, but it

[PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-22 Thread Yafang Shao
There's a space character missed in the printk messages. This error should be prevented with checkpatch.pl, but it couldn't caught by running with "checkpatch.pl -f .patch", that's what I had run before. What a carelessness. Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoin

Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-22 Thread Yafang Shao
On Sat, Dec 23, 2017 at 1:04 AM, Sergei Shtylyov wrote: > Hello! > > On 12/22/2017 06:37 PM, Yafang Shao wrote: > >> There's a space character missed in the printk messages. >> This error should be prevented with checkscript.pl, but it couldn't caught > >

Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-22 Thread Sergei Shtylyov
Hello! On 12/22/2017 06:37 PM, Yafang Shao wrote: There's a space character missed in the printk messages. This error should be prevented with checkscript.pl, but it couldn't caught ^ be? by running with "checkscript.pl -f

[PATCH net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-22 Thread Yafang Shao
There's a space character missed in the printk messages. This error should be prevented with checkscript.pl, but it couldn't caught by running with "checkscript.pl -f .patch", that's what I had run before. What a carelessness. Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepo