Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough

2020-08-19 Thread Saeed Mahameed
On Mon, 2020-08-03 at 10:48 -0500, Gustavo A. R. Silva wrote: > On Mon, Aug 03, 2020 at 05:34:48PM +0300, Dan Carpenter wrote: > > This isn't a fall through because it was after a return > > statement. The > > fall through annotation leads to a Smatch warning: > > > > drivers/net/ethernet/mel

Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough

2020-08-03 Thread Gustavo A. R. Silva
On Mon, Aug 03, 2020 at 05:34:48PM +0300, Dan Carpenter wrote: > This isn't a fall through because it was after a return statement. The > fall through annotation leads to a Smatch warning: > > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246 > mlx5e_ethtool_get_sset_count() warn:

[PATCH net-next] net/mlx5: remove erroneous fallthrough

2020-08-03 Thread Dan Carpenter
This isn't a fall through because it was after a return statement. The fall through annotation leads to a Smatch warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246 mlx5e_ethtool_get_sset_count() warn: ignoring unreachable code. Signed-off-by: Dan Carpenter --- drivers/ne