Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-03-15 Thread Pablo Neira Ayuso
On Wed, Mar 15, 2017 at 06:14:02PM +0200, Or Gerlitz wrote: > On Thu, Feb 23, 2017 at 7:54 PM, David Miller wrote: > > From: Andreas Schultz > > Date: Thu, 23 Feb 2017 18:19:16 +0100 (CET) > > > >> When we are talking about the xmit path, then currently none of the > >> receivers we are talking t

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-03-15 Thread Or Gerlitz
On Thu, Feb 23, 2017 at 7:54 PM, David Miller wrote: > From: Andreas Schultz > Date: Thu, 23 Feb 2017 18:19:16 +0100 (CET) > >> When we are talking about the xmit path, then currently none of the >> receivers we are talking to is going to be Linux and we have no >> idea how they will behave nor d

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread David Miller
From: Andreas Schultz Date: Thu, 23 Feb 2017 18:19:16 +0100 (CET) > When we are talking about the xmit path, then currently none of the > receivers we are talking to is going to be Linux and we have no > idea how they will behave nor do we have any influence on them. Do > we really need to make a

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread David Miller
From: Harald Welte Date: Thu, 23 Feb 2017 17:50:51 +0100 > I understand and support the motivation to design robust systsems even > in the presence of broken/ignorant specs, but I think this is one of the > situations where it is useless (and IMHO impossible) to do anything > about it. I think a

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Andreas Schultz
- On Feb 23, 2017, at 5:42 PM, pablo pa...@netfilter.org wrote: > On Thu, Feb 23, 2017 at 03:21:13PM +0100, Andreas Schultz wrote: >> - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > [...] >> > According to specs, section 4.4.2.3 Encapsulated T-PDU, TS 29.281. >> > >> >

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Harald Welte
Hi Tom, On Thu, Feb 23, 2017 at 08:35:13AM -0800, Tom Herbert wrote: > On Thu, Feb 23, 2017 at 6:00 AM, Pablo Neira Ayuso > wrote: > > On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: > >> - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > >> So in a co

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Pablo Neira Ayuso
On Thu, Feb 23, 2017 at 03:21:13PM +0100, Andreas Schultz wrote: > - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: [...] > > According to specs, section 4.4.2.3 Encapsulated T-PDU, TS 29.281. > > > > "The UDP Source Port is a locally allocated port number at the sending > > GTP

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Tom Herbert
On Thu, Feb 23, 2017 at 6:21 AM, Andreas Schultz wrote: > - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > >> On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: >>> On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >>> > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Sc

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Tom Herbert
On Thu, Feb 23, 2017 at 6:00 AM, Pablo Neira Ayuso wrote: > On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: >> - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > [...] >> > This shouldn't be taken as a HW requirement and it's unlikely we'd add >> > expli

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Andreas Schultz
- On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: >> On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >> > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz >> > wrote: >> >> Hi Or, >> >> - On Feb 16, 2017, a

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Pablo Neira Ayuso
On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: > - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: [...] > > This shouldn't be taken as a HW requirement and it's unlikely we'd add > > explicit GTP support in flow_dissector. If we can't get entropy in the

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Or Gerlitz
On 2/23/2017 3:49 PM, Pablo Neira Ayuso wrote: "The UDP Source Port is a locally allocated port number at the sending GTP-U entity." and the proposed patch goes in that direction, agree?

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Pablo Neira Ayuso
On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: > On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: > > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: > >> Hi Or, > >> - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: > >> > >>> Generate the source

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Andreas Schultz
Hi Tom, - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >> On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: >>> Hi Or, >>> - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: >>>

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-22 Thread Tom Herbert
On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: >> Hi Or, >> - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: >> >>> Generate the source udp header according to the flow represented by >>> the packet we are en

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-22 Thread Or Gerlitz
On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: > Hi Or, > - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: > >> Generate the source udp header according to the flow represented by >> the packet we are encapsulating, as done for other udp tunnels. This >> helps o

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-16 Thread Andreas Schultz
Hi Or, - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: > Generate the source udp header according to the flow represented by > the packet we are encapsulating, as done for other udp tunnels. This > helps on the receiver side to apply RSS spreading. This might work for

[PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-16 Thread Or Gerlitz
Generate the source udp header according to the flow represented by the packet we are encapsulating, as done for other udp tunnels. This helps on the receiver side to apply RSS spreading. Signed-off-by: Or Gerlitz --- found in code inspection.. compile tested only drivers/net/gtp.c | 5 -