Re: [PATCH net-next] net/core: fix for_each_netdev_feature

2015-11-03 Thread David Miller
From: Jarod Wilson Date: Tue, 3 Nov 2015 10:15:59 -0500 > As pointed out by Nikolay and further explained by Geert, the initial > for_each_netdev_feature macro was broken, as feature would get set outside > of the block of code it was intended to run in, thus only ever working for > the first fe

Re: [PATCH net-next] net/core: fix for_each_netdev_feature

2015-11-03 Thread Nikolay Aleksandrov
On 11/03/2015 04:15 PM, Jarod Wilson wrote: > As pointed out by Nikolay and further explained by Geert, the initial > for_each_netdev_feature macro was broken, as feature would get set outside > of the block of code it was intended to run in, thus only ever working for > the first feature bit in th

[PATCH net-next] net/core: fix for_each_netdev_feature

2015-11-03 Thread Jarod Wilson
As pointed out by Nikolay and further explained by Geert, the initial for_each_netdev_feature macro was broken, as feature would get set outside of the block of code it was intended to run in, thus only ever working for the first feature bit in the mask. While less pretty this way, this is tested a