Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 19:49:16 +0530 Naresh Kamboju wrote: > > > We must start the retransmission timer only there are > > > pending data in the rtx queue. > > > Otherwise we can hit a WARN_ON in mptcp_reset_timer(), > > > as syzbot demonstrated. > > > > > > Reported-and-tested-by: > > > syzbot+42aa

Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-19 Thread Naresh Kamboju
On Thu, 19 Nov 2020 at 06:13, Mat Martineau wrote: > > > On Wed, 18 Nov 2020, Paolo Abeni wrote: > > > We must start the retransmission timer only there are > > pending data in the rtx queue. > > Otherwise we can hit a WARN_ON in mptcp_reset_timer(), > > as syzbot demonstrated. > > > > Reported-an

Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-18 Thread Mat Martineau
On Wed, 18 Nov 2020, Paolo Abeni wrote: We must start the retransmission timer only there are pending data in the rtx queue. Otherwise we can hit a WARN_ON in mptcp_reset_timer(), as syzbot demonstrated. Reported-and-tested-by: syzbot+42aa53dafb66a07e5...@syzkaller.appspotmail.com Fixes: d9ca

[PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-18 Thread Paolo Abeni
We must start the retransmission timer only there are pending data in the rtx queue. Otherwise we can hit a WARN_ON in mptcp_reset_timer(), as syzbot demonstrated. Reported-and-tested-by: syzbot+42aa53dafb66a07e5...@syzkaller.appspotmail.com Fixes: d9ca1de8c0cd ("mptcp: move page frag allocation i