Re: [PATCH net-next] mptcp: don't skip needed ack

2020-10-06 Thread David Miller
From: Paolo Abeni Date: Mon, 5 Oct 2020 12:36:44 +0200 > Currently we skip calling tcp_cleanup_rbuf() when packets > are moved into the OoO queue or simply dropped. In both > cases we still increment tp->copied_seq, and we should > ask the TCP stack to check for ack. > > Fixes: c76c6956566f ("m

Re: [MPTCP] [PATCH net-next] mptcp: don't skip needed ack

2020-10-05 Thread Mat Martineau
On Mon, 5 Oct 2020, Paolo Abeni wrote: Currently we skip calling tcp_cleanup_rbuf() when packets are moved into the OoO queue or simply dropped. In both cases we still increment tp->copied_seq, and we should ask the TCP stack to check for ack. Fixes: c76c6956566f ("mptcp: call tcp_cleanup_rbuf

[PATCH net-next] mptcp: don't skip needed ack

2020-10-05 Thread Paolo Abeni
Currently we skip calling tcp_cleanup_rbuf() when packets are moved into the OoO queue or simply dropped. In both cases we still increment tp->copied_seq, and we should ask the TCP stack to check for ack. Fixes: c76c6956566f ("mptcp: call tcp_cleanup_rbuf on subflows") Signed-off-by: Paolo Abeni