Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue

2020-05-22 Thread Florian Westphal
Paolo Abeni wrote: > It looks like this way ssk rcvbuf will grow up to tcp_rmem[2] even if > there is no user-space reader - assuming the link is fast enough. > > Don't we need to somehow cap that? e.g. moving mptcp rcvbuf update in > mptcp_revmsg()? >From irc discussion it looks like you alread

Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue

2020-05-22 Thread Paolo Abeni
Hi, On Fri, 2020-05-22 at 14:43 +0200, Florian Westphal wrote: > TCP does tcp rcvbuf tuning when copying packets to userspace, e.g. in > tcp_read_sock(). In case of mptcp, that function is only rarely used > (when discarding retransmitted duplicate data). > > Instead, skbs are moved from the tcp

[PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue

2020-05-22 Thread Florian Westphal
TCP does tcp rcvbuf tuning when copying packets to userspace, e.g. in tcp_read_sock(). In case of mptcp, that function is only rarely used (when discarding retransmitted duplicate data). Instead, skbs are moved from the tcp rx queue to the mptcp socket rx queue. Adjust subflow rcvbuf when we do s