Re: [PATCH net-next] mpls: drop skb's dst in mpls_forward()

On Sat, 31 Oct 2020 01:07:25 +0100 Guillaume Nault wrote: > Commit 394de110a733 ("net: Added pointer check for > dst->ops->neigh_lookup in dst_neigh_lookup_skb") added a test in > dst_neigh_lookup_skb() to avoid a NULL pointer dereference. The root > cause was the MPLS forwarding code, which doesn'

[PATCH net-next] mpls: drop skb's dst in mpls_forward()

Commit 394de110a733 ("net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skb") added a test in dst_neigh_lookup_skb() to avoid a NULL pointer dereference. The root cause was the MPLS forwarding code, which doesn't call skb_dst_drop() on incoming packets. That is, if the packet