Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-02 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 09:07:48PM -0700, Nathan Chancellor wrote: > On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > > Clang warns: > > > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning:

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-01 Thread Nathan Chancellor
On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > > 'err' is used uninitialized whenever 'if' condition is true > >

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-05-31 Thread Leon Romanovsky
On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > 'err' is used uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (!priv->dbg_root) { > ^

[PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-05-29 Thread Nathan Chancellor
Clang warns: drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!priv->dbg_root) { ^~~ drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note: unin