Re: [PATCH net-next] macvtap: add namespace support to the sysfs device class

2016-04-28 Thread Marc Angel
On Mon, Apr 25, 2016 at 8:12 PM, Eric W. Biederman wrote: >> The 'net' device class is isolated between network namespaces so each >> one has its own hierarchy of net devices. >> This isn't the case for the 'macvtap' device class. >> The problem occurs half-way through the netdev registration, whe

Re: [PATCH net-next] macvtap: add namespace support to the sysfs device class

2016-04-25 Thread Eric W. Biederman
Marc Angel writes: > When creating macvtaps that are expected to have the same ifindex > in different network namespaces, only the first one will succeed. > The others will fail with a sysfs_warn_dup warning due to them trying > to create the following sysfs link (with 'NN' the ifindex of macvtap

Re: [PATCH net-next] macvtap: add namespace support to the sysfs device class

2016-04-24 Thread David Miller
From: Marc Angel Date: Wed, 20 Apr 2016 16:11:31 +0200 > However, doing this has the side effect of changing > /sys/devices/virtual/net/macvtapX/tapNN into > /sys/devices/virtual/net/macvtapX/macvtap/tapNN I'm really not comfortable at all with having this sysfs device name change.

[PATCH net-next] macvtap: add namespace support to the sysfs device class

2016-04-20 Thread Marc Angel
When creating macvtaps that are expected to have the same ifindex in different network namespaces, only the first one will succeed. The others will fail with a sysfs_warn_dup warning due to them trying to create the following sysfs link (with 'NN' the ifindex of macvtapX): /sys/class/macvtap/tapNN