Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-02 Thread Josef Bacik
On Thu, 2017-02-02 at 09:06 -0800, Eric Dumazet wrote: > On Thu, 2017-02-02 at 10:56 -0500, Josef Bacik wrote: > > > > > The problem is we set skb->pfmemalloc a bunch of different places, > > such > > as __skb_fill_page_desc, which appears to be used in both the RX > > and TX > > path, so we can'

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-02 Thread Eric Dumazet
On Thu, 2017-02-02 at 10:56 -0500, Josef Bacik wrote: > The problem is we set skb->pfmemalloc a bunch of different places, such > as __skb_fill_page_desc, which appears to be used in both the RX and TX > path, so we can't just kill it there. Do we want to go through and > audit each one, provide

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-02 Thread Josef Bacik
On Wed, 2017-02-01 at 15:38 -0800, Eric Dumazet wrote: > On Wed, 2017-02-01 at 16:04 -0500, Josef Bacik wrote: > > > > I was seeing random disconnects while testing NBD over > > loopback.  This turned > > out to be because NBD sets pfmemalloc on it's socket, however the > > receiving side > > is a

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 15:38 -0800, Eric Dumazet wrote: > I am not sure this is a proper fix. > > Presumably if the socket was able to store packets in its write queue, > fact that it sends it to loopback or an Ethernet link should not matter. > > Only in RX path the pfmemalloc thing is really im

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 15:38 -0800, Eric Dumazet wrote: > On Wed, 2017-02-01 at 16:04 -0500, Josef Bacik wrote: > > I was seeing random disconnects while testing NBD over loopback. This > > turned > > out to be because NBD sets pfmemalloc on it's socket, however the receiving > > side > > is a us

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 16:04 -0500, Josef Bacik wrote: > I was seeing random disconnects while testing NBD over loopback. This turned > out to be because NBD sets pfmemalloc on it's socket, however the receiving > side > is a user space application so does not have pfmemalloc set on its socket.

[PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Josef Bacik
I was seeing random disconnects while testing NBD over loopback. This turned out to be because NBD sets pfmemalloc on it's socket, however the receiving side is a user space application so does not have pfmemalloc set on its socket. This means that sk_filter_trim_cap will simply drop this packet,